Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Chai 4 #2862

Merged
merged 9 commits into from
Dec 5, 2018
Merged

Upgrade to Chai 4 #2862

merged 9 commits into from
Dec 5, 2018

Conversation

lilaconlee
Copy link
Contributor

@lilaconlee lilaconlee commented Nov 30, 2018 •
edited by jennifer-shehane
Loading

@chrisbreiding chrisbreiding mentioned this pull request Nov 30, 2018
Closed
31 tasks
@chrisbreiding chrisbreiding changed the base branch from develop to v4.0 December 3, 2018 20:04
lilaconlee
lilaconlee commented Dec 5, 2018
View reviewed changes
packages/driver/src/cy/commands/connectors.coffee
args = if subject?._spreadArray then args else [args]

try
hasSpreadArray = "_spreadArray" in subject or subject?._spreadArray
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for proxies or regular objects, but I don't love it. Would love any ideas for alternatives!

@chrisbreiding chrisbreiding merged commit d5bf693 into v4.0 Dec 5, 2018
@chrisbreiding chrisbreiding deleted the issue-2529-upgrade-chai branch December 5, 2018 17:10
@jennifer-shehane jennifer-shehane mentioned this pull request Apr 23, 2019
Closed
@chrisbreiding chrisbreiding mentioned this pull request May 21, 2019
Closed
18 tasks
chrisbreiding pushed a commit that referenced this pull request May 21, 2019
@lilaconlee @chrisbreiding
Upgrade to Chai 4 (#2862)
25f2a6d 
* Initial upgrade changes

* Some quick fixes

* More fixes

* Clean up exp logic and fix spread array failures

* Remove caret from package.json

* Add handling for proxies in isJquery

* iterate on flaky test, increase default command timeout
@jennifer-shehane jennifer-shehane mentioned this pull request Jul 15, 2019
Closed
@jennifer-shehane jennifer-shehane mentioned this pull request Mar 9, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2020
Open
@Tomastomaslol Tomastomaslol mentioned this pull request Aug 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann Awaiting requested review from brian-mann

@chrisbreiding chrisbreiding Awaiting requested review from chrisbreiding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilaconlee @chrisbreiding @brian-mann